Added documentation for validator message variables in File constraints #10584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Oct 29, 2018
…ile constraints (TimoBakx) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #10584). Discussion ---------- Added documentation for validator message variables in File constraints Fixed #10574. Also added some messages that seemed missing. Commits ------- bbaeb07 Added documentation for validator message variables in File constraints
|
@TimoBakx thanks for this big contribution! All these docs were missing so we appreciate that you added them. We merged this in 2.8 and tweaked it when merging it to the upper branches. Thanks! |
|
Thanks for the merge, @javiereguiluz. I'll take some time this week to go over the documentation of the other constraints and do the same thing there. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 31, 2018
…imoBakx) This PR was merged into the 2.8 branch. Discussion ---------- Added documentation for constraint message parameters After #10584, I checked the documentation for the other constraints and updated the possible parameters in messages. I also added missing documentation for `charsetMessage` in the Length constraint. Commits ------- ed3d366 Added documentation for message parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #10574.
Also added some messages that seemed missing.